Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.5] Improve app_command #2782

Merged
merged 2 commits into from
Aug 13, 2024
Merged

[2.5] Improve app_command #2782

merged 2 commits into from
Aug 13, 2024

Conversation

yanchengnv
Copy link
Collaborator

Fixes # .

Description

This PR improves app command implementation as follows:

  • Added docstring for do_app_command method in flare_api
  • Added sanity check against the cmd_data of do_app_command.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

yhwen
yhwen approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@yhwen yhwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

YuanTingHsieh
YuanTingHsieh approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuanTingHsieh
Copy link
Collaborator

/build

@YuanTingHsieh YuanTingHsieh merged commit 47e6fe4 into NVIDIA:main Aug 13, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhwen yhwen yhwen approved these changes

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

@nvkevlu nvkevlu Awaiting requested review from nvkevlu

@IsaacYangSLA IsaacYangSLA Awaiting requested review from IsaacYangSLA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yanchengnv @YuanTingHsieh @yhwen