Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the kill children processes #2789

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

yhwen
Copy link
Collaborator

@yhwen yhwen commented Aug 13, 2024

Fixes # .

Description

Change to use process.kill() to kill the children processes. This force kill the example like flow child process.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh
Copy link
Collaborator

@yhwen can you fix the unit test, one import is not needed anymore, thanks

@YuanTingHsieh
Copy link
Collaborator

/build

Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhwen yhwen merged commit 138387e into NVIDIA:main Aug 13, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants