Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-trained Model and training_mode changes #2793

Merged
merged 42 commits into from
Aug 14, 2024

Conversation

nvidianz
Copy link
Collaborator

Description

  1. Added support for pre-trained model in XGBoost. The model must reside in custom/model.json.
  2. Changed training_mode to split_mode and secure_training to align with XGBoost parameters.
  3. Merged changes made to main and changed all the examples to use split_mode.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, some codes are accidentally removed

Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, LGTM

Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you test this ? to have a pre-trained model in the json format ? custom/model.json

@nvidianz
Copy link
Collaborator Author

have you test this ? to have a pre-trained model in the json format ? custom/model.json

Yes. With the model there, the AUC improved a little bit.

@nvidianz nvidianz merged commit 2d731b9 into NVIDIA:main Aug 14, 2024
15 checks passed
@nvidianz nvidianz deleted the flare-2171-support-pre-trained-models branch August 14, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants