Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Jenkins CI #2812

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Fix Jenkins CI #2812

merged 4 commits into from
Aug 21, 2024

Conversation

YuanTingHsieh
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh commented Aug 19, 2024 •
edited
Loading

Description

Fix CI following recent changes of

  • Removing scanning of app_opt
  • Refactoring hello-xxx examples

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh YuanTingHsieh added the cicd continuous integration/continuous development label Aug 19, 2024
@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh YuanTingHsieh merged commit 71fd04b into NVIDIA:main Aug 21, 2024
16 checks passed
@YuanTingHsieh YuanTingHsieh deleted the fix_jenkins_ci branch August 21, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesterxgchen chesterxgchen chesterxgchen approved these changes

@nvkevlu nvkevlu Awaiting requested review from nvkevlu

@yhwen yhwen Awaiting requested review from yhwen

@IsaacYangSLA IsaacYangSLA Awaiting requested review from IsaacYangSLA

@SYangster SYangster Awaiting requested review from SYangster

Assignees
No one assigned
Labels
cicd continuous integration/continuous development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YuanTingHsieh @chesterxgchen