Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Job API Examples #2823

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Fix Job API Examples #2823

merged 1 commit into from
Aug 22, 2024

Conversation

SYangster
Copy link
Collaborator

@SYangster SYangster commented Aug 22, 2024 •
edited
Loading

  • We removed the configuration of DLControllerApp components (IntimeModelSelector, ValidationJsonGenerator, TBAnalyticsReceiver) and moved them into FedAvgJob in a previous PR. For examples using FedAvg/SAG with Job API, we must now change to use either FedAvgJob or explicitly configure IntimeModelSelector depending on structure.
  • Removing use of as_id() in examples to instead use returned ids

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

yanchengnv
yanchengnv requested changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments.

examples/advanced/job_api/sklearn/kmeans_script_executor_higgs.py Outdated Show resolved Hide resolved
examples/advanced/job_api/sklearn/kmeans_script_executor_higgs.py Outdated Show resolved Hide resolved
examples/advanced/job_api/sklearn/kmeans_script_executor_higgs.py Outdated Show resolved Hide resolved
examples/advanced/job_api/sklearn/kmeans_script_executor_higgs.py Outdated Show resolved Hide resolved
examples/getting_started/sklearn/kmeans_script_executor_higgs.py Outdated Show resolved Hide resolved
examples/getting_started/sklearn/kmeans_script_executor_higgs.py Outdated Show resolved Hide resolved
examples/getting_started/sklearn/kmeans_script_executor_higgs.py Outdated Show resolved Hide resolved
examples/getting_started/sklearn/kmeans_script_executor_higgs.py Outdated Show resolved Hide resolved
examples/getting_started/sklearn/kmeans_script_executor_higgs.py Outdated Show resolved Hide resolved
@SYangster SYangster force-pushed the fix_job_api_examples branch 2 times, most recently from c2bff5a to 8ef26a3 Compare August 22, 2024 04:47
@SYangster
Copy link
Collaborator Author

/build

@chesterxgchen chesterxgchen merged commit f766f90 into NVIDIA:main Aug 22, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanchengnv yanchengnv yanchengnv requested changes

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

@YuanTingHsieh YuanTingHsieh Awaiting requested review from YuanTingHsieh

@holgerroth holgerroth Awaiting requested review from holgerroth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SYangster @yanchengnv @chesterxgchen