Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ScriptRunner in ccwf_job #2825

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

yanchengnv
Copy link
Collaborator

Fixes # .

Description

The CCWFJob's SwarmClientConfig and CyclicClientConfig require the executor to be Executor. This will cause the type check to fail when using ScriptRunner as the executor, since ScriptRunner is not a true Executor.

Disabled the type check in CCWFJob.

Also improved ScriptRunner to return component IDs added to the job.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please double check the examples due to the return type changes

Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nvflare/app_common/ccwf/ccwf_job.py Show resolved Hide resolved
@YuanTingHsieh
Copy link
Collaborator

/build

@yanchengnv yanchengnv merged commit d7c92cf into NVIDIA:main Aug 22, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants