Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert step-by-step stats examples to use new Job API #2842

Merged
merged 7 commits into from
Aug 26, 2024

Conversation

chesterxgchen
Copy link
Collaborator

@chesterxgchen chesterxgchen commented Aug 24, 2024

Description

  1. add getting start notebook
  2. add StatsJob class to simplify the user experience
  3. convert higgs/df_stats and cifar10/image_stats from job template to job API

A few sentences describing the changes proposed in this pull request.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@chesterxgchen
Copy link
Collaborator Author

/build

@chesterxgchen chesterxgchen changed the title Convert step-by-step higgs/df_stats to use new Job API Convert step-by-step stats examples to use new Job API Aug 24, 2024
@chesterxgchen chesterxgchen force-pushed the higgs_stats2 branch 2 times, most recently from 3d02169 to ab8743f Compare August 26, 2024 16:09
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, added some comments

@YuanTingHsieh
Copy link
Collaborator

/build

YuanTingHsieh
YuanTingHsieh previously approved these changes Aug 26, 2024
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR LGTM, we might need to improve our docs

@chesterxgchen
Copy link
Collaborator Author

forgot to the change the real_id part, the documentation will be in separate PR, I will do one more update

2. convert df_stats from job template to job API
2) update both higgs and cifar10 stats using the new StatsJob to streamline the notebooks
@chesterxgchen
Copy link
Collaborator Author

/build

@chesterxgchen chesterxgchen merged commit 276d8f5 into NVIDIA:main Aug 26, 2024
16 checks passed
@chesterxgchen chesterxgchen deleted the higgs_stats2 branch August 26, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants