Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update arg name for MLflowReceiver #2850

Merged
merged 5 commits into from
Aug 27, 2024

Conversation

YuanTingHsieh
Copy link
Collaborator

The argument name is changed by #2839

from kwargs to kw_args

Description

  • Update corresponding places in our codebase.

We might need to document this / add to change log.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @yhwen these are the examples have to change due to your recent changes

@chesterxgchen
Copy link
Collaborator

/build

@YuanTingHsieh
Copy link
Collaborator Author

/build

@chesterxgchen chesterxgchen merged commit d26b96c into NVIDIA:main Aug 27, 2024
16 checks passed
@YuanTingHsieh YuanTingHsieh deleted the fix_arg_name_mlflow_receiver branch August 27, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants