Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added check for duplicate RM request #2858

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Added check for duplicate RM request #2858

merged 2 commits into from
Aug 27, 2024

Conversation

nvidianz
Copy link
Collaborator

Description

Added a check for duplicate ReliableMessage request so no duplicate message was received.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

yanchengnv
yanchengnv requested changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments.

nvflare/apis/utils/reliable_message.py Show resolved Hide resolved
nvflare/apis/utils/reliable_message.py Outdated Show resolved Hide resolved
yanchengnv
yanchengnv approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvidianz
Copy link
Collaborator Author

/build

1 similar comment
@YuanTingHsieh
Copy link
Collaborator

/build

@YuanTingHsieh YuanTingHsieh merged commit 7b01b0f into NVIDIA:main Aug 27, 2024
16 checks passed
@nvidianz nvidianz deleted the fix-rm-dup-message branch August 27, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanchengnv yanchengnv yanchengnv approved these changes

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

@YuanTingHsieh YuanTingHsieh Awaiting requested review from YuanTingHsieh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nvidianz @YuanTingHsieh @yanchengnv