Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix path due to simulator output structure changes #2885

Merged
merged 2 commits into from
Aug 30, 2024
Merged

fix path due to simulator output structure changes #2885

merged 2 commits into from
Aug 30, 2024

Conversation

chesterxgchen
Copy link
Collaborator

Fixes # .

Description

A few sentences describing the changes proposed in this pull request.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

YuanTingHsieh
YuanTingHsieh approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm, the new path contains duplicate site names maybe later we can enhance

@chesterxgchen
Copy link
Collaborator Author

/build

@chesterxgchen chesterxgchen merged commit 3a4e6b9 into NVIDIA:main Aug 30, 2024
16 checks passed
@chesterxgchen chesterxgchen deleted the notebook_fix branch August 30, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

@holgerroth holgerroth Awaiting requested review from holgerroth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chesterxgchen @YuanTingHsieh