Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CrossSiteEval #2886

Merged
merged 6 commits into from
Aug 30, 2024
Merged

Update CrossSiteEval #2886

merged 6 commits into from
Aug 30, 2024

Conversation

YuanTingHsieh
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh commented Aug 30, 2024 •
edited
Loading

get_model_from_location is only available in PTModelFilePersistor.

Description

  • Adds a check to make sure what's passed in is ModelPersistor
  • Change to a more generic get_model that is available for all ModelPersistor

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

SYangster
SYangster approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@SYangster SYangster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes, using get_model is much better

@YuanTingHsieh
Copy link
Collaborator Author

/build

@chesterxgchen
Copy link
Collaborator

/build

@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh YuanTingHsieh merged commit d708465 into NVIDIA:main Aug 30, 2024
16 checks passed
@YuanTingHsieh YuanTingHsieh deleted the update_cross_site_eval branch August 30, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SYangster SYangster SYangster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YuanTingHsieh @chesterxgchen @SYangster