Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update getting_started cifar notebook #2889

Merged
merged 4 commits into from
Aug 30, 2024
Merged

Update getting_started cifar notebook #2889

merged 4 commits into from
Aug 30, 2024

Conversation

ZiyueXu77
Copy link
Collaborator

Add TB streaming components to notebook per VDR finding

Description

A few sentences describing the changes proposed in this pull request.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@ZiyueXu77
Copy link
Collaborator Author

/build

@ZiyueXu77
Copy link
Collaborator Author

/build

@ZiyueXu77 ZiyueXu77 enabled auto-merge (squash) August 30, 2024 20:59
YuanTingHsieh
YuanTingHsieh approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chesterxgchen
Copy link
Collaborator

/build

@ZiyueXu77 ZiyueXu77 merged commit 5e5212e into NVIDIA:main Aug 30, 2024
16 checks passed
@ZiyueXu77 ZiyueXu77 deleted the update_cifar_notebook branch September 3, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SYangster SYangster SYangster left review comments

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZiyueXu77 @chesterxgchen @YuanTingHsieh @SYangster