Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed XGBoost Example README #2913

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Fixed XGBoost Example README #2913

merged 2 commits into from
Sep 5, 2024

Conversation

nvidianz
Copy link
Collaborator

@nvidianz nvidianz commented Sep 5, 2024

Description

Changed split_mode to data_split_mode in README file in XGBoost example folder.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@nvidianz
Copy link
Collaborator Author

nvidianz commented Sep 5, 2024

/build

chesterxgchen
chesterxgchen approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvidianz nvidianz merged commit 07343c9 into NVIDIA:main Sep 5, 2024
16 checks passed
@nvidianz nvidianz deleted the fix-xgb-script branch September 5, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesterxgchen chesterxgchen chesterxgchen approved these changes

@YuanTingHsieh YuanTingHsieh Awaiting requested review from YuanTingHsieh

@SYangster SYangster Awaiting requested review from SYangster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvidianz @chesterxgchen