Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to use BaseFedJob #2919

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Update to use BaseFedJob #2919

merged 1 commit into from
Sep 6, 2024

Conversation

SYangster
Copy link
Collaborator

Change getting started examples to use BaseFedJob to allow users to explicitly define controller

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

chesterxgchen
chesterxgchen previously approved these changes Sep 6, 2024
View reviewed changes
@chesterxgchen
Copy link
Collaborator

/build

@SYangster SYangster force-pushed the base_fed_job branch 2 times, most recently from 78d11a2 to 8ad2ad8 Compare September 6, 2024 00:37
holgerroth
holgerroth approved these changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@holgerroth holgerroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change.

@chesterxgchen
Copy link
Collaborator

/build

@chesterxgchen chesterxgchen merged commit 80bc167 into NVIDIA:main Sep 6, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerroth holgerroth holgerroth approved these changes

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SYangster @chesterxgchen @holgerroth