Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the memoryview issues #2926

Merged
merged 8 commits into from
Sep 7, 2024
Merged

Fixing the memoryview issues #2926

merged 8 commits into from
Sep 7, 2024

Conversation

nvidianz
Copy link
Collaborator

@nvidianz nvidianz commented Sep 6, 2024

Description

Made following changes to the F3 streaming code,

  1. Added lock to the reading of received data.
  2. Ignored duplicate chunks. GRPC may send duplicate requests.
  3. Defensively check the received data and make sure it doesn't exceed stream size. Log debug info if it did.
  4. Move the reading of configuration parameters to the constructor.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

chesterxgchen
chesterxgchen reviewed Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have a question

@nvidianz
Copy link
Collaborator Author

nvidianz commented Sep 6, 2024

/build

@nvidianz
Copy link
Collaborator Author

nvidianz commented Sep 6, 2024

/build

@nvidianz
Copy link
Collaborator Author

nvidianz commented Sep 6, 2024

/build

YuanTingHsieh
YuanTingHsieh approved these changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chesterxgchen
Copy link
Collaborator

/build

@YuanTingHsieh
Copy link
Collaborator

/build

@YuanTingHsieh YuanTingHsieh merged commit c278aff into NVIDIA:main Sep 7, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesterxgchen chesterxgchen chesterxgchen left review comments

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

@yanchengnv yanchengnv Awaiting requested review from yanchengnv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nvidianz @chesterxgchen @YuanTingHsieh