Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing memoryview error #2929

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Fixing memoryview error #2929

merged 2 commits into from
Sep 9, 2024

Conversation

nvidianz
Copy link
Collaborator

@nvidianz nvidianz commented Sep 9, 2024

Description

  1. Fixed a bug in handling duplicate seq 0 chunk which can happen with GRPC.
  2. Added more debug info in error logs.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@nvidianz
Copy link
Collaborator Author

nvidianz commented Sep 9, 2024

/build

@chesterxgchen chesterxgchen merged commit bff1d69 into NVIDIA:main Sep 9, 2024
16 checks passed
@nvidianz nvidianz deleted the fix-dup-seq-0-bug branch September 9, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesterxgchen chesterxgchen chesterxgchen approved these changes

@IsaacYangSLA IsaacYangSLA Awaiting requested review from IsaacYangSLA

@YuanTingHsieh YuanTingHsieh Awaiting requested review from YuanTingHsieh

@yanchengnv yanchengnv Awaiting requested review from yanchengnv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvidianz @chesterxgchen