Tpc-H feature branch #187
Merged
Tpc-H feature branch #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abellina
reviewed
May 29, 2024
abellina
reviewed
May 29, 2024
abellina
reviewed
May 29, 2024
abellina
reviewed
May 29, 2024
abellina
reviewed
May 29, 2024
utils/jvm_listener/src/main/scala/com/nvidia/spark/rapids/listener/Listener.scala
Show resolved
Hide resolved
mattahrens
reviewed
May 30, 2024
mattahrens
reviewed
May 30, 2024
mattahrens
reviewed
May 30, 2024
mattahrens
reviewed
May 30, 2024
mattahrens
reviewed
May 30, 2024
mattahrens
reviewed
May 30, 2024
mattahrens
reviewed
May 30, 2024
mattahrens
reviewed
May 30, 2024
mattahrens
reviewed
May 30, 2024
mattahrens
reviewed
May 30, 2024
mattahrens
reviewed
May 30, 2024
mattahrens
reviewed
May 30, 2024
mattahrens
reviewed
May 30, 2024
mattahrens
previously approved these changes
Jun 3, 2024
wjxiz1992
reviewed
Jun 4, 2024
There was a problem hiding this comment.
LGTM, just some nits. Let's also file some follow-up issues like:
- let NDS use
shared/andutils/content - organize more common parts. I imagine we can put lots of things into
utilsthat both NDS and NDH can leverage.
The main task guideline is still: #182
wjxiz1992
previously approved these changes
Jun 5, 2024
Signed-off-by: Sayed Bilal Bari <sbari@nvidia.com>
Signed-off-by: Sayed Bilal Bari <sbari@nvidia.com>
mattahrens
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These contain the working changes for a local power run for TPC-H as well as the refactoring required for de-duplication of code.
Major changes include following -