Support gpu version crossvalidator for LinearRegression #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bobby Wang <wbo4958@gmail.com>
Signed-off-by: Bobby Wang <wbo4958@gmail.com>
|
build |
leewyang
approved these changes
Jul 3, 2023
| coef_: List[float], | ||
| intercept_: float, | ||
| coef_: Union[List[float], List[List[float]]], | ||
| intercept_: Union[float, List[float]], |
There was a problem hiding this comment.
Wondering if just assuming lists here would simplify things elsewhere, where the single model is just represented as a list of one item.
There was a problem hiding this comment.
Wow, Good suggestion. I will file a followup PR to handle it not only for LinearRegression but also for RandomForest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.