Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly test failure by specifying the absolute tolerance #698

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

lijinf2
Copy link
Collaborator

@lijinf2 lijinf2 commented Jul 25, 2024

default relative tolerance 1.0e-6 is too small for small values. e.g.:

Obtained: 0.05323904405853512
Expected: 0.053238988191376575 ± 5.3e-08

Signed-off-by: Jinfeng <jinfengl@nvidia.com>
@lijinf2
Copy link
Collaborator Author

lijinf2 commented Jul 25, 2024

build

Copy link
Collaborator

@eordentlich eordentlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lijinf2 lijinf2 merged commit ee78888 into NVIDIA:branch-24.08 Jul 25, 2024
2 checks passed
@lijinf2 lijinf2 deleted the ci_nightly branch July 25, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants