Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Support Ascii function #712

Closed
amahussein opened this issue Jan 2, 2024 · 0 comments · Fixed by #796
Closed

[BUG] Support Ascii function #712

amahussein opened this issue Jan 2, 2024 · 0 comments · Fixed by #796
Assignees
@amahussein
Labels
audit_plugin Audit related tasks for RAPIDS plugin changes bug Something isn't working core_tools Scope the core module (scala)

Comments

@amahussein
Copy link
Collaborator

Describe the bug
Add support to Ascii function according to the most recent plugin changes:

plugin issue: NVIDIA/spark-rapids#9585
plugin PR: NVIDIA/spark-rapids#10054

--- temp/spark-rapids-tools/core/src/main/resources/supportedExprs.csv    2024-01-02 13:01:41.788233001 +0000
+++ temp/spark-rapids/tools/generated_files/supportedExprs.csv    2024-01-02 13:01:40.468231375 +0000
@@ -62,0 +63,2 @@
+Ascii,NS,ascii,This is disabled by default because it only supports strings starting with ASCII or Latin-1 characters after Spark 3.2.3; 3.3.1 and 3.4.0. Otherwise the results will not match the CPU.,project,input,NA,NA,NA,NA,NA,NA,NA,NA,NA,S,NA,NA,NA,NA,NA,NA,NA,NA
+Ascii,NS,ascii,This is disabled by default because it only supports strings starting with ASCII or Latin-1 characters after Spark 3.2.3; 3.3.1 and 3.4.0. Otherwise the results will not match the CPU.,project,result,NA,NA,NA,S,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA
@amahussein amahussein added bug Something isn't working ? - Needs Triage core_tools Scope the core module (scala) audit_plugin Audit related tasks for RAPIDS plugin changes and removed ? - Needs Triage labels Jan 2, 2024
@amahussein amahussein mentioned this issue Jan 24, 2024
Closed
@amahussein amahussein self-assigned this Feb 21, 2024
amahussein added a commit to amahussein/spark-rapids-tools that referenced this issue Feb 21, 2024
@amahussein
Sync up supported ops for 24.02 plugin release
e2ac6f6 
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>

Fixes NVIDIA#795, Fixes NVIDIA#721, Fixes NVIDIA#712

This code change is to sync the supported-ops in the tools with the
Plugin release 24.02.0
@amahussein amahussein mentioned this issue Feb 21, 2024
Merged
amahussein added a commit to amahussein/spark-rapids-tools that referenced this issue Feb 22, 2024
@amahussein
Sync up supported ops for 24.02 plugin release
0f3be9d 
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>

Fixes NVIDIA#795, Fixes NVIDIA#721, Fixes NVIDIA#712

This code change is to sync the supported-ops in the tools with the
Plugin release 24.02.0 in addition to disabling `JsonTuple`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amahussein amahussein

Labels
audit_plugin Audit related tasks for RAPIDS plugin changes bug Something isn't working core_tools Scope the core module (scala)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sync up supported ops for 24.02 plugin release amahussein/spark-rapids-tools
1 participant
@amahussein