Skip to content

Commit

Permalink
Keep only tests for exsisting features
Browse files Browse the repository at this point in the history
  • Loading branch information
wjxiz1992 committed Aug 20, 2020
1 parent f0024c3 commit 06e1522
Showing 1 changed file with 0 additions and 61 deletions.
61 changes: 0 additions & 61 deletions udf-compiler/src/test/scala/com/nvidia/spark/OpcodeSuite.scala
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ package com.nvidia.spark

import com.nvidia.spark.rapids.RapidsConf
import org.scalatest.FunSuite

import org.apache.spark.SparkConf
import org.apache.spark.sql.{Dataset, SparkSession}
import org.apache.spark.sql.expressions.UserDefinedFunction
Expand Down Expand Up @@ -57,10 +56,6 @@ class OpcodeSuite extends FunSuite {
ds2.show
}

def udfIsCompiled[T](ds: Dataset[T]) : Boolean = {
!ds.queryExecution.analyzed.toString().contains("UDF")
}

// START OF TESTS

test("not boolean") {
Expand Down Expand Up @@ -1886,60 +1881,4 @@ class OpcodeSuite extends FunSuite {
val ref = dataset.withColumn("new",lit("this is the string".getBytes("US-ASCII")))
checkEquiv(result, ref)
}

test("Float - isNaN - True") {
val myudf: (Float) => Boolean = a => {
a.isNaN()
}
val u = makeUdf(myudf)
val dataset = List(Float.NaN).toDF("x").repartition(1)
val result = dataset.withColumn("new", u(col("x")))
val ref = dataset.withColumn("new", lit(Float.NaN.isNaN))
assert(udfIsCompiled(result))
checkEquiv(result, ref)
}

test("Float - isNaN - False") {
val myudf: (Float) => Boolean = a => {
a.isNaN()
}
val u = makeUdf(myudf)
val dataset = List(2f).toDF("x").repartition(1)
val result = dataset.withColumn("new", u(col("x")))
val ref = dataset.withColumn("new", lit(false))
assert(udfIsCompiled(result))
checkEquiv(result, ref)
}

test("Double - isNaN - True") {
val myudf: (Double) => Boolean = a => {
a.isNaN()
}
val u = makeUdf(myudf)
val dataset = List(Double.NaN).toDF("x").repartition(1)
val result = dataset.withColumn("new", u(col("x")))
val ref = dataset.withColumn("new", lit(Double.NaN.isNaN))
assert(udfIsCompiled(result))
checkEquiv(result, ref)
}

test("Double - isNaN - False") {
val myudf: (Float) => Boolean = a => {
a.isNaN()
}
val u = makeUdf(myudf)
val dataset = List(2D).toDF("x").repartition(1)
val result = dataset.withColumn("new", u(col("x")))
val ref = dataset.withColumn("new", lit(false))
assert(udfIsCompiled(result))
checkEquiv(result, ref)
}

test("NaNvl") {
val dataset = List((2,Float.NaN),(3,Float.NaN)).toDF("x", "y").repartition(1)
val result = dataset.withColumn("new", nanvl(dataset.col("x"), dataset.col("y")))
dataset.show()
result.show()
result.explain(true)
}
}

0 comments on commit 06e1522

Please sign in to comment.