-
Notifications
You must be signed in to change notification settings - Fork 230
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Support spilling to disk directly via cuFile/GDS (#1313)
* support spilling to GDS Signed-off-by: Rong Ou <rong.ou@gmail.com> * address review comments * review feedback Signed-off-by: Rong Ou <rong.ou@gmail.com>
- Loading branch information
Showing
6 changed files
with
133 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
106 changes: 106 additions & 0 deletions
106
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsGdsStore.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| /* | ||
| * Copyright (c) 2020, NVIDIA CORPORATION. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.nvidia.spark.rapids | ||
|
|
||
| import java.io.File | ||
| import java.util.concurrent.ConcurrentHashMap | ||
|
|
||
| import ai.rapids.cudf._ | ||
| import com.nvidia.spark.rapids.StorageTier.StorageTier | ||
| import com.nvidia.spark.rapids.format.TableMeta | ||
|
|
||
| import org.apache.spark.sql.rapids.RapidsDiskBlockManager | ||
| import org.apache.spark.sql.types.DataType | ||
| import org.apache.spark.sql.vectorized.ColumnarBatch | ||
|
|
||
| /** A buffer store using GPUDirect Storage (GDS). */ | ||
| class RapidsGdsStore( | ||
| diskBlockManager: RapidsDiskBlockManager, | ||
| catalog: RapidsBufferCatalog = RapidsBufferCatalog.singleton) | ||
| extends RapidsBufferStore("gds", catalog) with Arm { | ||
| private[this] val sharedBufferFiles = new ConcurrentHashMap[RapidsBufferId, File] | ||
|
|
||
| override def createBuffer( | ||
| other: RapidsBuffer, | ||
| stream: Cuda.Stream): RapidsBufferBase = { | ||
| withResource(other.getMemoryBuffer) { otherBuffer => | ||
| val deviceBuffer = otherBuffer match { | ||
| case d: DeviceMemoryBuffer => d | ||
| case _ => throw new IllegalStateException("copying from buffer without device memory") | ||
| } | ||
| val id = other.id | ||
| val path = if (id.canShareDiskPaths) { | ||
| sharedBufferFiles.computeIfAbsent(id, _ => id.getDiskPath(diskBlockManager)) | ||
| } else { | ||
| id.getDiskPath(diskBlockManager) | ||
| } | ||
| // When sharing files, append to the file; otherwise, write from the beginning. | ||
| val fileOffset = if (id.canShareDiskPaths) { | ||
| // only one writer at a time for now when using shared files | ||
| path.synchronized { | ||
| CuFile.appendDeviceBufferToFile(path, deviceBuffer) | ||
| } | ||
| } else { | ||
| CuFile.writeDeviceBufferToFile(path, 0, deviceBuffer) | ||
| 0 | ||
| } | ||
| logDebug(s"Spilled to $path $fileOffset:${other.size} via GDS") | ||
| new RapidsGdsBuffer(id, fileOffset, other.size, other.meta, other.getSpillPriority) | ||
| } | ||
| } | ||
|
|
||
| class RapidsGdsBuffer( | ||
| id: RapidsBufferId, | ||
| fileOffset: Long, | ||
| size: Long, | ||
| meta: TableMeta, | ||
| spillPriority: Long) extends RapidsBufferBase(id, size, meta, spillPriority) { | ||
| override val storageTier: StorageTier = StorageTier.GDS | ||
|
|
||
| // TODO(rongou): cache this buffer to avoid repeated reads from disk. | ||
| override def getMemoryBuffer: DeviceMemoryBuffer = synchronized { | ||
| val path = if (id.canShareDiskPaths) { | ||
| sharedBufferFiles.get(id) | ||
| } else { | ||
| id.getDiskPath(diskBlockManager) | ||
| } | ||
| closeOnExcept(DeviceMemoryBuffer.allocate(size)) { buffer => | ||
| CuFile.readFileToDeviceBuffer(buffer, path, fileOffset) | ||
| logDebug(s"Created device buffer for $path $fileOffset:$size via GDS") | ||
| buffer | ||
| } | ||
| } | ||
|
|
||
| override protected def releaseResources(): Unit = { | ||
| // Buffers that share paths must be cleaned up elsewhere | ||
| if (id.canShareDiskPaths) { | ||
| sharedBufferFiles.remove(id) | ||
| } else { | ||
| val path = id.getDiskPath(diskBlockManager) | ||
| if (!path.delete() && path.exists()) { | ||
| logWarning(s"Unable to delete GDS spill path $path") | ||
| } | ||
| } | ||
| } | ||
|
|
||
| override def getColumnarBatch(sparkTypes: Array[DataType]): ColumnarBatch = { | ||
| withResource(getMemoryBuffer) { deviceBuffer => | ||
| columnarBatchFromDeviceBuffer(deviceBuffer, sparkTypes) | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters