Skip to content

Commit

Permalink
add doc for PR status checks
Browse files Browse the repository at this point in the history
  • Loading branch information
pxLi committed Jul 27, 2021
1 parent 61c4ce8 commit f0e2595
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -187,5 +187,18 @@ You can confirm that the update actually has happened by either inspecting its e
`git diff` first or simply reexecuting `git commit` right away. The second time no file
modification should be triggered by the copyright year update hook and the commit should succeed.

### Pull request status checks
A pull request should pass all status checks before merged.
#### signoff check
Please follow [sign-your-work](#sign-your-work) section, and make sure at least one commit in your pull request get signed-off.
#### blossom-ci
The check runs on NVIDIA self-hosted runner, a [project committer](.github/workflows/blossom-ci.yml#L36) can manually trigger it by commenting `build`. It includes following steps,
1. Mergeable check
2. Blackduck vulnerability check
3. Fetch merged code (merge the pull request HEAD into BASE branch, e.g. fea-001 into branch-x)
4. Run `mvn verify` and unit tests for multiple spark versions in parallel. Ref: [spark-premerge-build.sh](jenkins/spark-premerge-build.sh)

If fail, you can click the `Details` link of this check, and go to `Post processing -> Start post processing` to find the uploaded log.

## Attribution
Portions adopted from https://github.com/rapidsai/cudf/blob/main/CONTRIBUTING.md, https://github.com/NVIDIA/nvidia-docker/blob/main/CONTRIBUTING.md, and https://github.com/NVIDIA/DALI/blob/main/CONTRIBUTING.md

0 comments on commit f0e2595

Please sign in to comment.