Skip to content

Commit

Permalink
Added Spark-3.4.2 Shims (#9967)
Browse files Browse the repository at this point in the history
* added 342 shims

* Signing off

Signed-off-by: Raza Jafri <rjafri@nvidia.com>

* missed from upmerge

* Fixed Sequence size limit check

* Fixed the overflow check for addition and subtraction

* Updated test conditions

* removed unused file

* Added MockContextBase to 342

---------

Signed-off-by: Raza Jafri <rjafri@nvidia.com>
  • Loading branch information
razajafri authored Dec 28, 2023
1 parent a9c1d68 commit ff62883
Show file tree
Hide file tree
Showing 184 changed files with 363 additions and 3 deletions.
17 changes: 17 additions & 0 deletions aggregator/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -699,6 +699,23 @@
</dependency>
</dependencies>
</profile>
<profile>
<id>release342</id>
<activation>
<property>
<name>buildver</name>
<value>342</value>
</property>
</activation>
<dependencies>
<dependency>
<groupId>com.nvidia</groupId>
<artifactId>rapids-4-spark-delta-24x_${scala.binary.version}</artifactId>
<version>${project.version}</version>
<classifier>${spark.version.classifier}</classifier>
</dependency>
</dependencies>
</profile>
<profile>
<id>release350</id>
<activation>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
{"spark": "340"}
{"spark": "341"}
{"spark": "341db"}
{"spark": "342"}
{"spark": "350"}
{"spark": "351"}
spark-rapids-shim-json-lines ***/
Expand Down
5 changes: 3 additions & 2 deletions integration_tests/src/main/python/collection_ops_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
from string_test import mk_str_gen
import pyspark.sql.functions as f
import pyspark.sql.utils
from spark_session import with_cpu_session, with_gpu_session, is_before_spark_351
from spark_session import with_cpu_session, with_gpu_session, is_spark_350, is_before_spark_342, is_before_spark_340
from conftest import get_datagen_seed
from marks import allow_non_gpu

Expand Down Expand Up @@ -326,7 +326,8 @@ def test_sequence_illegal_boundaries(start_gen, stop_gen, step_gen):
@pytest.mark.parametrize('stop_gen', sequence_too_long_length_gens, ids=idfn)
@allow_non_gpu(*non_utc_allow)
def test_sequence_too_long_sequence(stop_gen):
msg = "Too long sequence" if is_before_spark_351() else "Unsuccessful try to create array with"
msg = "Too long sequence" if is_before_spark_342() \
or is_spark_350() else "Unsuccessful try to create array with"
assert_gpu_and_cpu_error(
# To avoid OOM, reduce the row number to 1, it is enough to verify this case.
lambda spark:unary_op_df(spark, stop_gen, 1).selectExpr(
Expand Down
6 changes: 6 additions & 0 deletions integration_tests/src/main/python/spark_session.py
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,9 @@ def is_before_spark_340():
def is_before_spark_341():
return spark_version() < "3.4.1"

def is_before_spark_342():
return spark_version() < "3.4.2"

def is_before_spark_350():
return spark_version() < "3.5.0"

Expand All @@ -217,6 +220,9 @@ def is_spark_350_or_later():
def is_spark_330():
return spark_version() == "3.3.0"

def is_spark_350():
return spark_version() == "3.5.0"

def is_spark_33X():
return "3.3.0" <= spark_version() < "3.4.0"

Expand Down
22 changes: 22 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,26 @@
<module>delta-lake/delta-24x</module>
</modules>
</profile>
<profile>
<id>release342</id>
<activation>
<property>
<name>buildver</name>
<value>342</value>
</property>
</activation>
<properties>
<buildver>342</buildver>
<spark.version>${spark342.version}</spark.version>
<spark.test.version>${spark342.version}</spark.test.version>
<parquet.hadoop.version>1.12.3</parquet.hadoop.version>
<iceberg.version>${spark330.iceberg.version}</iceberg.version>
<slf4j.version>2.0.6</slf4j.version>
</properties>
<modules>
<module>delta-lake/delta-24x</module>
</modules>
</profile>
<profile>
<id>release330cdh</id>
<activation>
Expand Down Expand Up @@ -732,6 +752,7 @@
<spark333.version>3.3.3</spark333.version>
<spark340.version>3.4.0</spark340.version>
<spark341.version>3.4.1</spark341.version>
<spark342.version>3.4.2</spark342.version>
<spark330cdh.version>3.3.0.3.3.7180.0-274</spark330cdh.version>
<spark332cdh.version>3.3.2.3.3.7190.0-91</spark332cdh.version>
<spark330db.version>3.3.0-databricks</spark330db.version>
Expand Down Expand Up @@ -785,6 +806,7 @@
332cdh,
340,
341,
342,
350
</noSnapshot.buildvers>
<snapshot.buildvers>
Expand Down
17 changes: 17 additions & 0 deletions scala2.13/aggregator/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -699,6 +699,23 @@
</dependency>
</dependencies>
</profile>
<profile>
<id>release342</id>
<activation>
<property>
<name>buildver</name>
<value>342</value>
</property>
</activation>
<dependencies>
<dependency>
<groupId>com.nvidia</groupId>
<artifactId>rapids-4-spark-delta-24x_${scala.binary.version}</artifactId>
<version>${project.version}</version>
<classifier>${spark.version.classifier}</classifier>
</dependency>
</dependencies>
</profile>
<profile>
<id>release350</id>
<activation>
Expand Down
22 changes: 22 additions & 0 deletions scala2.13/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,26 @@
<module>delta-lake/delta-24x</module>
</modules>
</profile>
<profile>
<id>release342</id>
<activation>
<property>
<name>buildver</name>
<value>342</value>
</property>
</activation>
<properties>
<buildver>342</buildver>
<spark.version>${spark342.version}</spark.version>
<spark.test.version>${spark342.version}</spark.test.version>
<parquet.hadoop.version>1.12.3</parquet.hadoop.version>
<iceberg.version>${spark330.iceberg.version}</iceberg.version>
<slf4j.version>2.0.6</slf4j.version>
</properties>
<modules>
<module>delta-lake/delta-24x</module>
</modules>
</profile>
<profile>
<id>release330cdh</id>
<activation>
Expand Down Expand Up @@ -732,6 +752,7 @@
<spark333.version>3.3.3</spark333.version>
<spark340.version>3.4.0</spark340.version>
<spark341.version>3.4.1</spark341.version>
<spark342.version>3.4.2</spark342.version>
<spark330cdh.version>3.3.0.3.3.7180.0-274</spark330cdh.version>
<spark332cdh.version>3.3.2.3.3.7190.0-91</spark332cdh.version>
<spark330db.version>3.3.0-databricks</spark330db.version>
Expand Down Expand Up @@ -785,6 +806,7 @@
332cdh,
340,
341,
342,
350
</noSnapshot.buildvers>
<snapshot.buildvers>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
{"spark": "333"}
{"spark": "340"}
{"spark": "341"}
{"spark": "342"}
{"spark": "350"}
{"spark": "351"}
spark-rapids-shim-json-lines ***/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
{"spark": "333"}
{"spark": "340"}
{"spark": "341"}
{"spark": "342"}
{"spark": "350"}
{"spark": "351"}
spark-rapids-shim-json-lines ***/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
{"spark": "333"}
{"spark": "340"}
{"spark": "341"}
{"spark": "342"}
{"spark": "350"}
{"spark": "351"}
spark-rapids-shim-json-lines ***/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
{"spark": "333"}
{"spark": "340"}
{"spark": "341"}
{"spark": "342"}
spark-rapids-shim-json-lines ***/
package com.nvidia.spark.rapids.shims

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
{"spark": "333"}
{"spark": "340"}
{"spark": "341"}
{"spark": "342"}
{"spark": "350"}
{"spark": "351"}
spark-rapids-shim-json-lines ***/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
{"spark": "333"}
{"spark": "340"}
{"spark": "341"}
{"spark": "342"}
{"spark": "350"}
{"spark": "351"}
spark-rapids-shim-json-lines ***/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
{"spark": "340"}
{"spark": "341"}
{"spark": "341db"}
{"spark": "342"}
spark-rapids-shim-json-lines ***/
package com.nvidia.spark.rapids.shims

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
{"spark": "340"}
{"spark": "341"}
{"spark": "341db"}
{"spark": "342"}
spark-rapids-shim-json-lines ***/
package com.nvidia.spark.rapids.shims

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
{"spark": "333"}
{"spark": "340"}
{"spark": "341"}
{"spark": "342"}
spark-rapids-shim-json-lines ***/
package com.nvidia.spark.rapids.shims

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
{"spark": "333"}
{"spark": "340"}
{"spark": "341"}
{"spark": "342"}
{"spark": "350"}
{"spark": "351"}
spark-rapids-shim-json-lines ***/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
{"spark": "333"}
{"spark": "340"}
{"spark": "341"}
{"spark": "342"}
{"spark": "350"}
{"spark": "351"}
spark-rapids-shim-json-lines ***/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
{"spark": "333"}
{"spark": "340"}
{"spark": "341"}
{"spark": "342"}
{"spark": "350"}
{"spark": "351"}
spark-rapids-shim-json-lines ***/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
{"spark": "333"}
{"spark": "340"}
{"spark": "341"}
{"spark": "342"}
{"spark": "350"}
{"spark": "351"}
spark-rapids-shim-json-lines ***/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
{"spark": "333"}
{"spark": "340"}
{"spark": "341"}
{"spark": "342"}
spark-rapids-shim-json-lines ***/
package org.apache.spark.sql.execution.rapids.shims

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
{"spark": "333"}
{"spark": "340"}
{"spark": "341"}
{"spark": "342"}
spark-rapids-shim-json-lines ***/
package org.apache.spark.sql.hive.rapids.shims

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
{"spark": "333"}
{"spark": "340"}
{"spark": "341"}
{"spark": "342"}
spark-rapids-shim-json-lines ***/
package org.apache.spark.sql.hive.rapids.shims

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
{"spark": "333"}
{"spark": "340"}
{"spark": "341"}
{"spark": "342"}
spark-rapids-shim-json-lines ***/
package org.apache.spark.sql.hive.rapids.shims

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
{"spark": "333"}
{"spark": "340"}
{"spark": "341"}
{"spark": "342"}
spark-rapids-shim-json-lines ***/
package org.apache.spark.sql.rapids.execution

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
{"spark": "333"}
{"spark": "340"}
{"spark": "341"}
{"spark": "342"}
{"spark": "350"}
{"spark": "351"}
spark-rapids-shim-json-lines ***/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
{"spark": "333"}
{"spark": "340"}
{"spark": "341"}
{"spark": "342"}
spark-rapids-shim-json-lines ***/
package org.apache.spark.sql.rapids.execution.python.shims

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
{"spark": "333"}
{"spark": "340"}
{"spark": "341"}
{"spark": "342"}
{"spark": "350"}
{"spark": "351"}
spark-rapids-shim-json-lines ***/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
{"spark": "333"}
{"spark": "340"}
{"spark": "341"}
{"spark": "342"}
{"spark": "350"}
{"spark": "351"}
spark-rapids-shim-json-lines ***/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
{"spark": "340"}
{"spark": "341"}
{"spark": "341db"}
{"spark": "342"}
spark-rapids-shim-json-lines ***/
package org.apache.spark.sql.rapids.shims

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
{"spark": "340"}
{"spark": "341"}
{"spark": "341db"}
{"spark": "342"}
spark-rapids-shim-json-lines ***/
package org.apache.spark.sql.rapids.shims

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
{"spark": "340"}
{"spark": "341"}
{"spark": "341db"}
{"spark": "342"}
{"spark": "350"}
{"spark": "351"}
spark-rapids-shim-json-lines ***/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
{"spark": "340"}
{"spark": "341"}
{"spark": "341db"}
{"spark": "342"}
{"spark": "350"}
{"spark": "351"}
spark-rapids-shim-json-lines ***/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
{"spark": "333"}
{"spark": "340"}
{"spark": "341"}
{"spark": "342"}
{"spark": "350"}
{"spark": "351"}
spark-rapids-shim-json-lines ***/
Expand Down
Loading

0 comments on commit ff62883

Please sign in to comment.