Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] doc links fail with 404 for shims.md #10029

Closed
revans2 opened this issue Dec 12, 2023 · 0 comments · Fixed by #10030
Closed

[BUG] doc links fail with 404 for shims.md #10029

revans2 opened this issue Dec 12, 2023 · 0 comments · Fixed by #10030
Assignees
@revans2
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@revans2
Copy link
Collaborator

revans2 commented Dec 12, 2023

Describe the bug

 [✖] https://github.com/NVIDIA/spark-rapids/blob/main/sql-plugin/src/main/scala/com/nvidia/spark/rapids/ShimLoader.scala → Status: 404
[✓] https://github.com/NVIDIA/spark-rapids/blob/6a82213a798a81a5f32f8cf8b4c630e38d112f65/sql-plugin/src/main/spark311/scala/com/nvidia/spark/rapids/shims/TreeNode.scala#L28 → Status: 200
[✓] https://github.com/NVIDIA/spark-rapids/blob/6a82213a798a81a5f32f8cf8b4c630e38d112f65/sql-plugin/src/main/spark320/scala/com/nvidia/spark/rapids/shims/TreeNode.scala#L37 → Status: 200
[✓] https://contributors.scala-lang.org/t/scala-signature-layout/3327/4 → Status: 200
[✖] https://github.com/NVIDIA/spark-rapids/blob/main/sql-plugin/src/main/scala/com/nvidia/spark/SQLPlugin.scala#L29 → Status: 404

It looks like #9506 moved the files, but didn't update the links in the docs. I don't know why it took this long to start failing the pre-commit.
@revans2 revans2 added bug Something isn't working documentation Improvements or additions to documentation ? - Needs Triage Need team to review and classify labels Dec 12, 2023
@revans2 revans2 self-assigned this Dec 12, 2023
@revans2 revans2 linked a pull request Dec 12, 2023 that will close this issue
Update links in shims.md #10030
Merged
@revans2 revans2 mentioned this issue Dec 12, 2023
Merged
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@revans2 revans2

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update links in shims.md revans2/spark-rapids
2 participants
@revans2 @mattahrens