Move ProxyShuffleInternalManagerBase to api [databricks] #9506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- moves ProxyShuffleInternalManagerBase to sql-plugin-api module along with the required dependencies including ShimLoader - Leave the parts of ShimLoader that cannot moved now as ShimLoaderTemp Signed-off-by: Gera Shegalov <gera@apache.org>
Signed-off-by: Gera Shegalov <gera@apache.org>
gerashegalov
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008,
NvTimLiu and
pxLi
as code owners
Signed-off-by: Gera Shegalov <gera@apache.org>
gerashegalov
changed the title
|
build |
1 similar comment
|
build |
jlowe
previously approved these changes
Oct 23, 2023
sql-plugin/src/main/scala/com/nvidia/spark/rapids/ShimLoaderTemp.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Gera Shegalov <gera@apache.org>
jlowe
previously approved these changes
Oct 23, 2023
|
build |
abellina
reviewed
Oct 23, 2023
sql-plugin-api/src/main/scala/com/nvidia/spark/rapids/ShimLoader.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Gera Shegalov <gera@apache.org>
jlowe
previously approved these changes
Oct 23, 2023
|
had to resolve a conflict again |
|
build |
jlowe
approved these changes
Oct 24, 2023
gerashegalov
added a commit
that referenced
this pull request
Oct 24, 2023
…9444) Closes #9456 Contributes to #6565 - additionally remove unsued pom properties - remove unnecessary unshimmed*txt entries missed in #9506 - get shuffle manager definition to the point of an easy template, probably can be a shimplify feature ```scala /*** spark-rapids-shim-json-lines {"spark": "${buldver}"} spark-rapids-shim-json-lines ***/ package com.nvidia.spark.rapids.spark${buldver} import org.apache.spark.SparkConf import org.apache.spark.shuffle.rapids.ProxyRapidsShuffleInternalManagerBase /** A shuffle manager optimized for the RAPIDS Plugin for Apache Spark. */ sealed class RapidsShuffleManager( conf: SparkConf, isDriver: Boolean ) extends ProxyRapidsShuffleInternalManagerBase(conf, isDriver) ``` Signed-off-by: Gera Shegalov <gera@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is taken from #9444 to separate the aspect of moving ProxyShuffleInternalManagerBase
to the sql-plugin-api module
with the required dependencies including ShimLoader
on spark classes in the API module as well
Signed-off-by: @gerashegalov