Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Support a more readable diff when timestamp values are different between CPU and GPU #10039

Open
Tracked by #6839
NVnavkumar opened this issue Dec 13, 2023 · 0 comments
Open
Tracked by #6839

[FEA] Support a more readable diff when timestamp values are different between CPU and GPU #10039

NVnavkumar opened this issue Dec 13, 2023 · 0 comments
Labels
test Only impacts tests

Comments

@NVnavkumar
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
After #9996 is merged, we patch the TimestampType (and others) to support comparing the internal representations when running integration tests in Python. When these values are actually different, we should be able to see a more readable value. Bonus if we can configure this to turn on or off (probably through an environment variable).
@NVnavkumar NVnavkumar added feature request New feature or request ? - Needs Triage Need team to review and classify test Only impacts tests labels Dec 13, 2023
@NVnavkumar NVnavkumar mentioned this issue Dec 13, 2023
Merged
@mattahrens mattahrens removed feature request New feature or request ? - Needs Triage Need team to review and classify labels Dec 19, 2023
@sameerz sameerz mentioned this issue Dec 19, 2023
Open
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test Only impacts tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattahrens @NVnavkumar