Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Support time zones that are not UTC #6839

Open
23 of 47 tasks
revans2 opened this issue Oct 18, 2022 · 5 comments
Open
23 of 47 tasks

[FEA] Support time zones that are not UTC #6839

revans2 opened this issue Oct 18, 2022 · 5 comments
Labels
epic Issue that encompasses a significant feature or body of work feature request New feature or request

Comments

@revans2
Copy link
Collaborator

revans2 commented Oct 18, 2022

Is your feature request related to a problem? Please describe.
This is related to #6603 but a super set of it. I will list out the issues here to complete both sets of work, and then reference some of them in #6603 too.

The following are the tasks to do:

Phase I (P0) - Release 23.12

Phase II (P0) - Release 24.02

Phase III/Uncategorized (P1)

Uncategorized

Test improvements

Benchmarking

In general we are going to try to have timestamps follow what Spark does and store them in UTC. Then convert the inputs to the desired timezone whenever we need to operate on it in a different time zone.

We should also go through other operators and see if there are things that we can/should support once we can support timezones.

@revans2 revans2 added feature request New feature or request ? - Needs Triage Need team to review and classify epic Issue that encompasses a significant feature or body of work labels Oct 18, 2022
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Oct 18, 2022
@nvliyuan
Copy link
Collaborator

nvliyuan commented Jul 27, 2023

Not sure if FromUTCTimestamp support PST should be a sub task.
CC @viadea

@res-life
Copy link
Collaborator

Follow on issue: #9570

@revans2
Copy link
Collaborator Author

revans2 commented Nov 3, 2023

Adding in some issues for testing too

#9627

#9633

@res-life
Copy link
Collaborator

res-life commented Nov 28, 2023

Test cases statistics:

code snapshot TZ passed skipped xfailed xpassed total
Before xfail all the impacted cases #9773 UTC 19361 2210 373 283 22227
After xfail all the impacted cases #9773 non-UTC 7589 2214 3719 8613 22135
Introduced fine grained checker from #9719 non-UTC 20173 1411 358 382 22324

@res-life
Copy link
Collaborator

Not planing work on this for release 24.04
@sameerz can we move it to next release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic Issue that encompasses a significant feature or body of work feature request New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants