Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test tag for precommit time zone tests #10041

Closed
Tracked by #6839
revans2 opened this issue Dec 13, 2023 · 2 comments
Closed
Tracked by #6839

Add integration test tag for precommit time zone tests #10041

revans2 opened this issue Dec 13, 2023 · 2 comments
Assignees
Labels
test Only impacts tests

Comments

@revans2
Copy link
Collaborator

revans2 commented Dec 13, 2023

From #9999 (comment)_

It would be nice to have the pre-merge build run tests in different time zones that are tagged in the tests themselves instead of having a hard coded list in the pre-merge script.

@revans2 revans2 added ? - Needs Triage Need team to review and classify test Only impacts tests labels Dec 13, 2023
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Dec 19, 2023
@sperlingxx
Copy link
Collaborator

Hi @revans2, currently the time zone test pieces of pre-merge tests look like:

    source "$(dirname "$0")"/test-timezones.sh
    for tz in "${time_zones_test_cases[@]}"
    do
        TZ=$tz ./integration_tests/run_pyspark_from_build.sh -m tz_sensitive_test
    done

It has the specialized test tag tz_sensitive_test. And selected timezones are managed in test-timezones.sh.

Does it look good to you?

@revans2
Copy link
Collaborator Author

revans2 commented Jan 11, 2024

Yes it looks great.

@revans2 revans2 closed this as completed Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

No branches or pull requests

3 participants