Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Unchecked type warning in SparkQueryCompareTestSuite #1115

Closed
jlowe opened this issue Nov 13, 2020 · 1 comment
Closed

[BUG] Unchecked type warning in SparkQueryCompareTestSuite #1115

jlowe opened this issue Nov 13, 2020 · 1 comment
Labels
bug Something isn't working P1 Nice to have for release test Only impacts tests

Comments

@jlowe
Copy link
Member

jlowe commented Nov 13, 2020

Describe the bug
Compiling the code results in this warning in SparkQueryCompareTestSuite:

[WARNING] /home/jlowe/src/rapids-plugin-4-spark/tests/src/test/scala/com/nvidia/spark/rapids/SparkQueryCompareTestSuite.scala:821: abstract type T is unchecked since it is eliminated by erasure
[WARNING]           case Failure(e) if e.isInstanceOf[T] => {

If I'm reading that error message correctly, the condition on that case is not being treated properly.
@jlowe jlowe added bug Something isn't working ? - Needs Triage Need team to review and classify labels Nov 13, 2020
@sameerz sameerz added test Only impacts tests and removed ? - Needs Triage Need team to review and classify labels Nov 17, 2020
@sameerz sameerz added the P1 Nice to have for release label Nov 17, 2020
@jlowe jlowe mentioned this issue Nov 23, 2020
Merged
@jlowe
Copy link
Member Author

jlowe commented Nov 23, 2020

Fixed by #1186

@jlowe jlowe closed this as completed Nov 23, 2020
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
@pxLi
Pin urllib3<2.0 to resolve requests lib issue for CI scripts [skip ci] (
de99513 
NVIDIA#1115)

* Pin urllib3<2.0 to resolve requests lib issue for CI scripts

Signed-off-by: Peixin Li <pxli@nyu.edu>

* include action dockerfile update

Signed-off-by: Peixin Li <pxli@nyu.edu>

---------

Signed-off-by: Peixin Li <pxli@nyu.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working P1 Nice to have for release test Only impacts tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlowe @sameerz