Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Fix high priority violations detected by code analysis tools #2109

Closed
gerashegalov opened this issue Apr 9, 2021 · 0 comments · Fixed by #2168, #2172 or #2222
Closed

[BUG] Fix high priority violations detected by code analysis tools #2109

gerashegalov opened this issue Apr 9, 2021 · 0 comments · Fixed by #2168, #2172 or #2222
Assignees
@gerashegalov
Labels
audit_3.2.0 bug Something isn't working P0 Must have for release
Milestone
Apr 12 - Apr 23

Comments

@gerashegalov
Copy link
Collaborator

Describe the bug
Running IDEA's code analysis tool uncovers sources of potential bugs such as using map instead of foreach.

Steps/Code to reproduce bug
IDEA->Analyze->Inspect Code

Expected behavior
No semantic errors

Environment details (please complete the following information)
Source code

Additional context
See apache/spark@830249284d
@gerashegalov gerashegalov added bug Something isn't working ? - Needs Triage Need team to review and classify audit_3.2.0 labels Apr 9, 2021
@sameerz sameerz added P0 Must have for release and removed ? - Needs Triage Need team to review and classify labels Apr 13, 2021
@sameerz sameerz added this to the Apr 12 - Apr 23 milestone Apr 15, 2021
This was referenced Apr 16, 2021
Closed
Merged
@gerashegalov gerashegalov linked a pull request Apr 16, 2021 that will close this issue
Simplify GpuExpressions w/ withResourceIfAllowed #2168
Merged
gerashegalov added a commit to gerashegalov/spark-rapids that referenced this issue Apr 17, 2021
@gerashegalov
Remove unused symbols. Contributes to NVIDIA#2109
a128d26 
Signed-off-by: Gera Shegalov <gera@apache.org>
gerashegalov added a commit to gerashegalov/spark-rapids that referenced this issue Apr 17, 2021
@gerashegalov
Remove unused symbols. Contributes to NVIDIA#2109
20db73c 
Signed-off-by: Gera Shegalov <gera@apache.org>
@gerashegalov gerashegalov mentioned this issue Apr 17, 2021
Merged
@gerashegalov gerashegalov linked a pull request Apr 17, 2021 that will close this issue
Remove easy unused symbols #2172
Merged
gerashegalov added a commit that referenced this issue Apr 19, 2021
@gerashegalov
Simplify GpuExpressions w/ withResourceIfAllowed (#2168)
2305157 
Signed-off-by: Gera Shegalov <gera@apache.org>

Contributes to #2109. Replaces unnecessary typechecks for AutoCloseable with `withResourceIfAllowed`
@gerashegalov gerashegalov reopened this Apr 19, 2021
@gerashegalov gerashegalov mentioned this issue Apr 20, 2021
Merged
@gerashegalov gerashegalov reopened this Apr 20, 2021
@gerashegalov gerashegalov mentioned this issue Apr 20, 2021
Merged
gerashegalov added a commit that referenced this issue Apr 21, 2021
@gerashegalov
Avoid redundant collection conversions (#2210)
d0964b5 
Contributes to #2109 
- unnecessary toSeq
- .size on Array or String causes conversion to SeqLike
- use mnemonic isEmpty/nonEmpty where possible
- substitute map for unzip

Signed-off-by: Gera Shegalov <gera@apache.org>
gerashegalov added a commit that referenced this issue Apr 21, 2021
@gerashegalov
Fix index-based access to the head elements (#2192)
7e66f53 
Signed-off-by: Gera Shegalov <gera@apache.org>

Fix simple collection operations. Contributes to #2109 
- replace map with foreach when the return value is not used
- forall where appropriate
- access head elements without specifying indices.
- simplify index iteration
@gerashegalov gerashegalov mentioned this issue Apr 21, 2021
Merged
@gerashegalov gerashegalov linked a pull request Apr 21, 2021 that will close this issue
Remove groupId already specified in parent pom #2222
Merged
gerashegalov added a commit that referenced this issue Apr 21, 2021
@gerashegalov
Remove groupId already specified in parent pom (#2222)
57ae7ea 
Signed-off-by: Gera Shegalov <gera@apache.org>

Minor maven cleanup. Contributes to #2109
nartal1 pushed a commit to nartal1/spark-rapids that referenced this issue Jun 9, 2021
@gerashegalov
Simplify GpuExpressions w/ withResourceIfAllowed (NVIDIA#2168)
435a7b8 
Signed-off-by: Gera Shegalov <gera@apache.org>

Contributes to NVIDIA#2109. Replaces unnecessary typechecks for AutoCloseable with `withResourceIfAllowed`
nartal1 pushed a commit to nartal1/spark-rapids that referenced this issue Jun 9, 2021
@gerashegalov
Avoid redundant collection conversions (NVIDIA#2210)
086aa76 
Contributes to NVIDIA#2109 
- unnecessary toSeq
- .size on Array or String causes conversion to SeqLike
- use mnemonic isEmpty/nonEmpty where possible
- substitute map for unzip

Signed-off-by: Gera Shegalov <gera@apache.org>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this issue Jun 9, 2021
@gerashegalov
Fix index-based access to the head elements (NVIDIA#2192)
1b43da5 
Signed-off-by: Gera Shegalov <gera@apache.org>

Fix simple collection operations. Contributes to NVIDIA#2109 
- replace map with foreach when the return value is not used
- forall where appropriate
- access head elements without specifying indices.
- simplify index iteration
nartal1 pushed a commit to nartal1/spark-rapids that referenced this issue Jun 9, 2021
@gerashegalov
Remove groupId already specified in parent pom (NVIDIA#2222)
9cefb57 
Signed-off-by: Gera Shegalov <gera@apache.org>

Minor maven cleanup. Contributes to NVIDIA#2109
nartal1 pushed a commit to nartal1/spark-rapids that referenced this issue Jun 9, 2021
@gerashegalov
Simplify GpuExpressions w/ withResourceIfAllowed (NVIDIA#2168)
ac60fa0 
Signed-off-by: Gera Shegalov <gera@apache.org>

Contributes to NVIDIA#2109. Replaces unnecessary typechecks for AutoCloseable with `withResourceIfAllowed`
nartal1 pushed a commit to nartal1/spark-rapids that referenced this issue Jun 9, 2021
@gerashegalov
Avoid redundant collection conversions (NVIDIA#2210)
206b1cf 
Contributes to NVIDIA#2109 
- unnecessary toSeq
- .size on Array or String causes conversion to SeqLike
- use mnemonic isEmpty/nonEmpty where possible
- substitute map for unzip

Signed-off-by: Gera Shegalov <gera@apache.org>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this issue Jun 9, 2021
@gerashegalov
Fix index-based access to the head elements (NVIDIA#2192)
a027049 
Signed-off-by: Gera Shegalov <gera@apache.org>

Fix simple collection operations. Contributes to NVIDIA#2109 
- replace map with foreach when the return value is not used
- forall where appropriate
- access head elements without specifying indices.
- simplify index iteration
nartal1 pushed a commit to nartal1/spark-rapids that referenced this issue Jun 9, 2021
@gerashegalov
Remove groupId already specified in parent pom (NVIDIA#2222)
9a167eb 
Signed-off-by: Gera Shegalov <gera@apache.org>

Minor maven cleanup. Contributes to NVIDIA#2109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gerashegalov gerashegalov

Labels
audit_3.2.0 bug Something isn't working P0 Must have for release
Projects
None yet
Milestone
Apr 12 - Apr 23
2 participants
@gerashegalov @sameerz