Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Decimal 128 Support: Extend the range for Decimal Multiply and Divide #3886

Closed
revans2 opened this issue Oct 21, 2021 · 0 comments · Fixed by #3900
Closed

[FEA] Decimal 128 Support: Extend the range for Decimal Multiply and Divide #3886

revans2 opened this issue Oct 21, 2021 · 0 comments · Fixed by #3900
Assignees
Labels
feature request New feature or request

Comments

@revans2
Copy link
Collaborator

revans2 commented Oct 21, 2021

Multiply and Divide have a far reduced range compared to Spark, in part because of PromotePrecision and the requirement that a Binop has the same type for the lhs and rhs of the operation. CUDF does not have any requirement like that for decimal binops. So we can increase the number of operations that we can put on the GPU if we create new versions of GpuMultiply and GpuDivide specifically for decimal that do not require that the precision and scale be the same. It would take a desired output type as well as the inputs and do its best to figure out based off of what CUDF does internally how to get the correct answer. We would then do pattern matching trying to strip out the PromotePrecision/Cast on the inputs to this, and also remove the CheckOverflow at the end of it.

@revans2 revans2 added feature request New feature or request ? - Needs Triage Need team to review and classify labels Oct 21, 2021
@revans2 revans2 self-assigned this Oct 21, 2021
@revans2 revans2 added this to the Oct 18 - Oct 29 milestone Oct 22, 2021
@revans2 revans2 linked a pull request Oct 22, 2021 that will close this issue
@Salonijain27 Salonijain27 removed the ? - Needs Triage Need team to review and classify label Oct 26, 2021
@revans2 revans2 closed this as completed Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants