Extend range of supported decimal divide operations #3891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revans2
added
the
task
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
revans2
force-pushed
the
decimal128_extended_divide
branch
from
257bdb8
to
0285638
Compare
This was referenced Oct 22, 2021
abellina
reviewed
Oct 22, 2021
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuOverrides.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/arithmetic.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
|
@abellina please take another look. I updated the comments to hopefully explain better what it is doing. |
abellina
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the range of what we can support for divide n decimal it is a part of #3886 but does not finish it. I will work on multiply after this is in.