Decimal Average Support #3898
Merged
Decimal Average Support #3898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
|
From my side, I'll come up with a patch against this (but I may need your help to test it), so I wouldn't worry too much about the conflict. I am also fine if it doesn't go into branch-21.12 yet, so I don't think we need to worry about the two diverging. |
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
abellina
reviewed
Oct 22, 2021
shims/spark320/src/main/scala/com/nvidia/spark/rapids/shims/spark320/Spark320Shims.scala
Show resolved
Hide resolved
| // First pass replace any operations that should be totally replaced. | ||
| val replacePass = expr.transformDown { | ||
| case GpuWindowExpression( | ||
| GpuAggregateExpression(rep: GpuReplaceWindowFunction, _, _, _, _), spec) => |
There was a problem hiding this comment.
Indentation seems a little off
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/AggregateFunctions.scala
Outdated
Show resolved
Hide resolved
|
for the doc request, I think we can just do as a follow up too. |
jlowe
reviewed
Oct 22, 2021
shims/spark320/src/main/scala/com/nvidia/spark/rapids/shims/spark320/Spark320Shims.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/AggregateFunctions.scala
Outdated
Show resolved
Hide resolved
|
@abellina @jlowe @sperlingxx please take another look |
jlowe
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on #3891
It also includes some rework of reduction by @abellina but he is working on a more complete fix from what I understand in #3833 so we might have to redo things yet again depending on how that goes in.
This fixes #3880