Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] unused method with a misleading outdated comment in ShimLoader #4213

Closed
gerashegalov opened this issue Nov 24, 2021 · 1 comment · Fixed by #4212
Closed

[BUG] unused method with a misleading outdated comment in ShimLoader #4213

gerashegalov opened this issue Nov 24, 2021 · 1 comment · Fixed by #4212
Assignees
@gerashegalov
Labels
bug Something isn't working
Milestone
Nov 15 - Nov 26

Comments

@gerashegalov
Copy link
Collaborator

Describe the bug
setSparkShimProviderClass is no longer used and the corresponding comment is irrelevant. We support shim overrides without using this method
@gerashegalov gerashegalov added bug Something isn't working ? - Needs Triage Need team to review and classify labels Nov 24, 2021
@gerashegalov gerashegalov self-assigned this Nov 24, 2021
@gerashegalov gerashegalov added this to the Nov 15 - Nov 26 milestone Nov 24, 2021
@gerashegalov gerashegalov removed the ? - Needs Triage Need team to review and classify label Nov 24, 2021
@gerashegalov gerashegalov mentioned this issue Nov 24, 2021
Merged
@gerashegalov gerashegalov linked a pull request Nov 24, 2021 that will close this issue
Remove an unused method with its outdated comment #4212
Merged
gerashegalov added a commit that referenced this issue Nov 24, 2021
@gerashegalov
Remove an unused method with its outdated comment (#4212)
18875c8 
Minor cleanup in ShimLoader.scala
- unused method `setSparkShimProviderClass` that used to power the shim override option
- unnecessary self-reference in `newExplainPlan`

Fixes #4213 

Signed-off-by: Gera Shegalov <gera@apache.org>
@gerashegalov
Copy link
Collaborator Author

closed by #4212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gerashegalov gerashegalov

Labels
bug Something isn't working
Projects
None yet
Milestone
Nov 15 - Nov 26
Development

Successfully merging a pull request may close this issue.

Remove an unused method with its outdated comment gerashegalov/spark-rapids
1 participant
@gerashegalov