Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Enable StringLPad #438

Closed
sameerz opened this issue Jul 27, 2020 · 1 comment · Fixed by #445
Closed

[FEA] Enable StringLPad #438

sameerz opened this issue Jul 27, 2020 · 1 comment · Fixed by #445
Assignees
Labels
feature request New feature or request

Comments

@sameerz
Copy link
Collaborator

sameerz commented Jul 27, 2020

Is your feature request related to a problem? Please describe.
Support https://spark.apache.org/docs/latest/api/sql/#lpad . CUDF provides a pad function: https://docs.rapids.ai/api/cudf/stable/api.html#cudf.core.column.string.StringMethods.pad

Describe the solution you'd like
Allow Spark SQL queries to use the lpad function on strings.

@sameerz sameerz added feature request New feature or request ? - Needs Triage Need team to review and classify and removed ? - Needs Triage Need team to review and classify labels Jul 27, 2020
@revans2
Copy link
Collaborator

revans2 commented Jul 27, 2020

To make this work we are going to have to put in JNI bindings for cudf::strings::pad_side, cudf::strings::pad, and cudf::strings::slice_strings so we can match the truncate that spark does for strings that are too long.

@revans2 revans2 self-assigned this Jul 27, 2020
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
[auto-merge] bot-auto-merge-branch-22.08 to branch-22.10 [skip ci] [bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants