Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] regexp_find hangs with some patterns #4487

Closed
andygrove opened this issue Jan 10, 2022 · 1 comment · Fixed by #4885
Closed

[BUG] regexp_find hangs with some patterns #4487

andygrove opened this issue Jan 10, 2022 · 1 comment · Fixed by #4885
Assignees
Labels
bug Something isn't working cudf_dependency An issue or PR with this label depends on a new feature in cudf

Comments

@andygrove
Copy link
Contributor

andygrove commented Jan 10, 2022

Describe the bug
A clear and concise description of what the bug is.

Steps/Code to reproduce bug

Add this test to RegularExpressionTranspilerSuite.

test("adhoc") {
  val patterns = Seq("(3?)+")
  val inputs = Seq("3aZ")
  assertCpuGpuMatchesRegexpFind(patterns, inputs)
}

Expected behavior
This should not hang. We either need to fix the underlying bug in cuDF, or we need to detect cases where this happens and fall back to CPU.

Environment details (please complete the following information)
None

Additional context
Related cuDF Issue: rapidsai/cudf#10006

@andygrove andygrove added bug Something isn't working ? - Needs Triage Need team to review and classify labels Jan 10, 2022
@andygrove andygrove added this to the Jan 10 - Jan 28 milestone Jan 10, 2022
@andygrove andygrove self-assigned this Jan 10, 2022
@andygrove andygrove added the cudf_dependency An issue or PR with this label depends on a new feature in cudf label Jan 10, 2022
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Jan 11, 2022
@andygrove andygrove removed this from the Jan 10 - Jan 28 milestone Jan 18, 2022
@andygrove andygrove removed their assignment Jan 20, 2022
@andygrove
Copy link
Contributor Author

The underlying issue has now been resolved in cuDF so we should re-test this by re-enabling the related fuzz tests (the code has comments linking to this issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cudf_dependency An issue or PR with this label depends on a new feature in cudf
Projects
None yet
3 participants