Patterns such (3?)+ should now fall back to CPU #4715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rted by cuDF and should fallback to CPU
Signed-off-by: Navin Kumar <navink@nvidia.com>
andygrove
reviewed
Feb 8, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RegexParser.scala
Outdated
Show resolved
Hide resolved
andygrove
reviewed
Feb 8, 2022
tests/src/test/scala/com/nvidia/spark/rapids/RegularExpressionTranspilerSuite.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Navin Kumar <navink@nvidia.com>
sameerz
added
the
task
andygrove
reviewed
Feb 15, 2022
tests/src/test/scala/com/nvidia/spark/rapids/RegularExpressionTranspilerSuite.scala
Outdated
Show resolved
Hide resolved
… in order to avoid hanging on the GPU Signed-off-by: Navin Kumar <navink@nvidia.com>
Signed-off-by: Navin Kumar <navink@nvidia.com>
Signed-off-by: Navin Kumar <navink@nvidia.com>
andygrove
reviewed
Feb 17, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RegexParser.scala
Outdated
Show resolved
Hide resolved
andygrove
reviewed
Feb 17, 2022
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RegexParser.scala
Outdated
Show resolved
Hide resolved
NVnavkumar
changed the title
|
build |
andygrove
approved these changes
Feb 17, 2022
Signed-off-by: Navin Kumar <navink@nvidia.com>
jlowe
approved these changes
Feb 18, 2022
|
|
||
| private def isSupportedRepetitionBase(e: RegexAST): Boolean = { | ||
| e match { | ||
| case RegexEscaped(ch) if ch != 'd' && ch != 'w' => // example: "\B?" |
There was a problem hiding this comment.
Nit: Comments should be consistent
Suggested change
| case RegexEscaped(ch) if ch != 'd' && ch != 'w' => // example: "\B?" | |
| case RegexEscaped(ch) if ch != 'd' && ch != 'w' => | |
| // example: "\B?" |
| case (RegexChar(a), _) if "$^".contains(a) => | ||
| // example: "$*" | ||
| throw new RegexUnsupportedException(nothingToRepeat) | ||
| case (_, QuantifierFixedLength(0)) | (_, QuantifierVariableLength(0,Some(0))) |
There was a problem hiding this comment.
Suggested change
| case (_, QuantifierFixedLength(0)) | (_, QuantifierVariableLength(0,Some(0))) | |
| case (_, QuantifierFixedLength(0)) | (_, QuantifierVariableLength(0, Some(0))) |
| throw new RegexUnsupportedException(nothingToRepeat) | ||
|
|
||
| case _ => | ||
| case (RegexGroup(_, term), QuantifierVariableLength(_,None)) |
There was a problem hiding this comment.
Suggested change
| case (RegexGroup(_, term), QuantifierVariableLength(_,None)) | |
| case (RegexGroup(_, term), QuantifierVariableLength(_, None)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #4487.
Previously patterns like
(3?)+or(\A)+would hang inlibcudf. In some cases, that has now been corrected upstream and will now thrown an exception as an unsupported pattern. This fix will intercept these patterns in the transpiler to throw the appropriateRegexUnsupportedExceptionFuzz testing currently brings up more possible edge cases that break in the plugin, so this is only considered a partial fix at moment. Further testing can be performed to finally handle the remaining edge cases.