Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] JSON reader should parse non-boolean values as null #4779

Closed
andygrove opened this issue Feb 14, 2022 · 1 comment · Fixed by #10542
Closed

[FEA] JSON reader should parse non-boolean values as null #4779

andygrove opened this issue Feb 14, 2022 · 1 comment · Fixed by #10542
Assignees
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request

Comments

@andygrove
Copy link
Contributor

andygrove commented Feb 14, 2022

Is your feature request related to a problem? Please describe.
When parsing the following JSON file and specifying that the number column is a boolean type, Spark will produce the values true and null, but on GPU we would produce true for both rows (once #4780 is merged).

There is a similar issue with numeric values.

{ "number": true }
{ "number": "true" }

Describe the solution you'd like
We should have consistent behavior with Spark. We need to remove the XFAIL from the test in json_test.py that references this issue.

Describe alternatives you've considered
None

Additional context
Depends on rapidsai/cudf#10283

@andygrove andygrove added feature request New feature or request ? - Needs Triage Need team to review and classify cudf_dependency An issue or PR with this label depends on a new feature in cudf labels Feb 14, 2022
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Feb 15, 2022
@andygrove andygrove mentioned this issue Feb 15, 2022
62 tasks
@andygrove andygrove changed the title [FEA] JSON reader should parse quoted boolean values as null [FEA] JSON reader should parse non-boolean values as null Nov 6, 2023
@revans2
Copy link
Collaborator

revans2 commented Feb 26, 2024

This is true for from_json/JsonToStructs too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants