Improve JSON and CSV support for boolean values #4780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Grove <andygrove@nvidia.com>
revans2
previously approved these changes
Feb 14, 2022
andygrove
changed the title
|
build |
|
build |
andygrove
changed the title
|
I found some edge cases that are not handled correctly so I am moving this back to draft / WIP for now |
andygrove
changed the title
|
build |
revans2
approved these changes
Feb 15, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andy Grove andygrove@nvidia.com
Closes #2071 and #4763
This PR improves support for reading boolean values from JSON and CSV by reading the values as strings in cuDF and then applying a CAST operation to parse the string as boolean with compatibility with Spark.
This does not work correctly for JSON where there are strings as input (such as
"true"rather thantrue) and there is a follow-on issue #4779 to fix this