Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Optimize Spark33XShims to reduce code deplicate #5150

Closed
res-life opened this issue Apr 6, 2022 · 0 comments · Fixed by #5195
Closed

[BUG] Optimize Spark33XShims to reduce code deplicate #5150

res-life opened this issue Apr 6, 2022 · 0 comments · Fixed by #5195
Assignees
Labels
audit_3.3.0 Audit related tasks for 3.3.0 improve

Comments

@res-life
Copy link
Collaborator

res-life commented Apr 6, 2022

Describe the bug

Some operators of ANSI interval types were copied from GpuOverrides only with the differentce of type checks.
It would be nice to shim the types to pass rather than make a copy of the entire override that has to be kept in sync other than just which types to pass as parameters. This applies elsewhere where we're making a copy only to update the type checks.

Check all the operators in Spark33XShims

Additional context
Refer to #5020
This PR shimed the types for some operators like UnaryMinus, Add, Subtract, UnaryPositive ......, need to check others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit_3.3.0 Audit related tasks for 3.3.0 improve
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant