Support multiplication on ANSI interval types #5105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chong Gao <res_life@163.com>
|
build |
|
build |
firestarman
reviewed
Apr 1, 2022
sql-plugin/src/main/330+/scala/org/apache/spark/sql/rapids/shims/intervalExpressions.scala
Outdated
Show resolved
Hide resolved
firestarman
reviewed
Apr 1, 2022
sql-plugin/src/main/330+/scala/org/apache/spark/sql/rapids/shims/intervalExpressions.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/330+/scala/org/apache/spark/sql/rapids/shims/intervalExpressions.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/330+/scala/org/apache/spark/sql/rapids/shims/intervalExpressions.scala
Outdated
Show resolved
Hide resolved
firestarman
reviewed
Apr 1, 2022
|
|
||
| longResult.incRefCount() | ||
| } | ||
| case _: FloatType => // num is float |
There was a problem hiding this comment.
Did you try
case FloatType | DoubleType => interval.mul(numOperable, DType.FLOAT64)
instead of separating the float and double ?
firestarman
reviewed
Apr 1, 2022
sql-plugin/src/main/330+/scala/org/apache/spark/sql/rapids/shims/intervalExpressions.scala
Outdated
Show resolved
Hide resolved
| * if(x == Long.MIN_VALUE && y == -1) throw exception | ||
| * | ||
| * @param x long cv or scalar | ||
| * @param y long cv or scalar, will not be scalar if x is scalar |
There was a problem hiding this comment.
y is declared to be a column vector in the below function, can not be a scalar.
There was a problem hiding this comment.
Updated the comments.
sql-plugin/src/main/330+/scala/org/apache/spark/sql/rapids/shims/intervalExpressions.scala
Outdated
Show resolved
Hide resolved
| * @param y long cv or scalar, will not be scalar if x is scalar | ||
| * @param r is the result of x * y | ||
| */ | ||
| def checkMultiplyOverflowSimpleImp(x: BinaryOperable, y: ColumnVector, |
There was a problem hiding this comment.
The postfix Imp, personally , is not suitable here. Usually it is used in a class declaration for implementing an interface, or a concrete method declaration implementing an abstract method.
|
Waiting #5150 to merge, has some conflict on |
added 2 commits
April 11, 2022 18:09
|
build |
|
build |
1 similar comment
|
build |
|
build |
jlowe
reviewed
Apr 12, 2022
sql-plugin/src/main/330+/scala/org/apache/spark/sql/rapids/shims/intervalExpressions.scala
Outdated
Show resolved
Hide resolved
|
build |
|
build |
|
build |
jlowe
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes #4151
Supports
Note: not support decimal type because of CUDF Decimal128 does not handle overflow, like:
Signed-off-by: Chong Gao res_life@163.com