Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Sanity checks for cudf jar mismatch #764

Closed
jlowe opened this issue Sep 14, 2020 · 0 comments · Fixed by #1047
Closed

[FEA] Sanity checks for cudf jar mismatch #764

jlowe opened this issue Sep 14, 2020 · 0 comments · Fixed by #1047
Assignees
Labels
feature request New feature or request good first issue Good for newcomers P0 Must have for release

Comments

@jlowe
Copy link
Member

jlowe commented Sep 14, 2020

Is your feature request related to a problem? Please describe.
There have been a number of cases reported recently where users are inadvertently matching an incorrect version of cudf with the plugin. It would be nice if the plugin could detect these mismatches and report them directly rather than crashing with NoSuchMethodError exceptions or other weird behaviors.

Describe the solution you'd like
The plugin should leverage the cudf Java build details feature requested at rapidsai/cudf#6229

Describe alternatives you've considered
We could walk the jars on the classpath looking for the cudf jar and parse it's name to try to extract build details, but this is problematic. For example, the user could have repackaged the plugin and cudf jars into an aggregate jar that appears to be neither the plugin nor the cudf jar by its name.

@jlowe jlowe added feature request New feature or request good first issue Good for newcomers ? - Needs Triage Need team to review and classify labels Sep 14, 2020
@sameerz sameerz added P0 Must have for release and removed ? - Needs Triage Need team to review and classify labels Sep 15, 2020
@sameerz sameerz added this to the Oct 26 - Nov 6 milestone Oct 23, 2020
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
Co-authored-by: Raza Jafri <rjafri@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request good first issue Good for newcomers P0 Must have for release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants