Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Update GpuRunningWindowExec to use OOM retry framework #7809

Closed
Tracked by #8029
abellina opened this issue Feb 23, 2023 · 0 comments · Fixed by #8170
Closed
Tracked by #8029

[FEA] Update GpuRunningWindowExec to use OOM retry framework #7809

abellina opened this issue Feb 23, 2023 · 0 comments · Fixed by #8170
Assignees
@andygrove
Labels
reliability Features to improve reliability or bugs that severly impact the reliability of the plugin

Comments

@abellina
Copy link
Collaborator

The running window exec first calls computeBasicWindow and then proceeds to do extra work to fix up the result from this in order to handle window partitions that cross batches.

The computeBasicWindow call is getting retried as handled by #7254. The fix up logic needs extra retry handling, if OOMs were to happen while working on the fixers.

This issue is to handle the running window specifically.
@abellina abellina added feature request New feature or request ? - Needs Triage Need team to review and classify reliability Features to improve reliability or bugs that severly impact the reliability of the plugin labels Feb 23, 2023
This was referenced Feb 23, 2023
Closed
Merged
@sameerz sameerz removed feature request New feature or request ? - Needs Triage Need team to review and classify labels Feb 28, 2023
@revans2 revans2 mentioned this issue Apr 4, 2023
Closed
6 tasks
@andygrove andygrove mentioned this issue Apr 21, 2023
Merged
@andygrove andygrove mentioned this issue May 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andygrove andygrove

Labels
reliability Features to improve reliability or bugs that severly impact the reliability of the plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update GpuRunningWindowExec to use OOM retry framework andygrove/spark-rapids
3 participants
@andygrove @abellina @sameerz