Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use RAPIDS shuffle when running TPCH and Mortgage tests #1000

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Oct 21, 2020

This removes the alpha-features profile which was originally intended to isolate the RAPIDS shuffle for unit tests. Instead the rapids.shuffle.manager.override property that it would override to true now always defaults to true. This causes a few tests that examine that property to start using the RAPIDS shuffle plugin by default. The legacy shuffle can still be run for those tests by running the tests with -Drapids.shuffle.manager.override=false.

Fixes #989

@jlowe jlowe added the test Only impacts tests label Oct 21, 2020
@jlowe jlowe added this to the Oct 12 - Oct 23 milestone Oct 21, 2020
@jlowe jlowe self-assigned this Oct 21, 2020
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
@jlowe jlowe force-pushed the tests-enable-rapids-shuffle branch from 2fccf09 to 768c85c Compare October 21, 2020 18:24
@jlowe
Copy link
Member Author

jlowe commented Oct 21, 2020

build

@jlowe jlowe merged commit 75957a7 into NVIDIA:branch-0.3 Oct 21, 2020
@jlowe jlowe deleted the tests-enable-rapids-shuffle branch October 21, 2020 20:13
sperlingxx pushed a commit to sperlingxx/spark-rapids that referenced this pull request Nov 20, 2020
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
…IDIA#1000)

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Smoke test for RAPIDS shuffle
3 participants