ColumnarBatch to CachedBatch and back #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Write ColumnarBatch to CachedBatch and Read CachedBatch into ColumnarBatch Sign off empty-commit Signed-off-by: Raza Jafri <rjafri@nvidia.com>
razajafri
requested review from
GaryShen2008,
jlowe,
NvTimLiu,
revans2 and
tgravescs
as code owners
revans2
reviewed
Oct 22, 2020
...310/src/main/scala/com/nvidia/spark/rapids/shims/spark310/ParquetCachedBatchSerializer.scala
Outdated
Show resolved
Hide resolved
...310/src/main/scala/com/nvidia/spark/rapids/shims/spark310/ParquetCachedBatchSerializer.scala
Show resolved
Hide resolved
...310/src/main/scala/com/nvidia/spark/rapids/shims/spark310/ParquetCachedBatchSerializer.scala
Show resolved
Hide resolved
...310/src/main/scala/com/nvidia/spark/rapids/shims/spark310/ParquetCachedBatchSerializer.scala
Show resolved
Hide resolved
...310/src/main/scala/com/nvidia/spark/rapids/shims/spark310/ParquetCachedBatchSerializer.scala
Outdated
Show resolved
Hide resolved
...n/scala/org/apache/spark/sql/execution/datasources/parquet/RapidsVectorizedColumnReader.java
Outdated
Show resolved
Hide resolved
jlowe
changed the title
Let me clean it up more and add docs. |
Removed RapidsVectorizedColumnReader in favor of Reflection on VectorizedColumnReader
razajafri
commented
Oct 23, 2020
...310/src/main/scala/com/nvidia/spark/rapids/shims/spark310/ParquetCachedBatchSerializer.scala
Show resolved
Hide resolved
...310/src/main/scala/com/nvidia/spark/rapids/shims/spark310/ParquetCachedBatchSerializer.scala
Show resolved
Hide resolved
...310/src/main/scala/com/nvidia/spark/rapids/shims/spark310/ParquetCachedBatchSerializer.scala
Show resolved
Hide resolved
| val num = Math.min(capacity.toLong, totalCountLoadedSoFar - rowsReturned).toInt | ||
| for (i <- columnReaders.indices) { | ||
| if (columnReaders(i) != null) { | ||
| val readBatchMethod = |
There was a problem hiding this comment.
I have moved this up at the class level so we don't have to look it up every time. Update coming soon
|
build |
|
build |
revans2
previously approved these changes
Oct 26, 2020
jlowe
reviewed
Oct 26, 2020
...310/src/main/scala/com/nvidia/spark/rapids/shims/spark310/ParquetCachedBatchSerializer.scala
Outdated
Show resolved
Hide resolved
...310/src/main/scala/com/nvidia/spark/rapids/shims/spark310/ParquetCachedBatchSerializer.scala
Outdated
Show resolved
Hide resolved
...310/src/main/scala/com/nvidia/spark/rapids/shims/spark310/ParquetCachedBatchSerializer.scala
Outdated
Show resolved
Hide resolved
|
build |
jlowe
approved these changes
Oct 27, 2020
sperlingxx
pushed a commit
to sperlingxx/spark-rapids
that referenced
this pull request
Nov 20, 2020
Write ColumnarBatch to CachedBatch and Read CachedBatch into ColumnarBatch Sign off empty-commit Signed-off-by: Raza Jafri <rjafri@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Write ColumnarBatch to CachedBatch and Read CachedBatch into ColumnarBatch Sign off empty-commit Signed-off-by: Raza Jafri <rjafri@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Write ColumnarBatch to CachedBatch and Read CachedBatch into ColumnarBatch Sign off empty-commit Signed-off-by: Raza Jafri <rjafri@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
…IDIA#1001) Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write ColumnarBatch to CachedBatch and Read CachedBatch into ColumnarBatch
When writing ColumnarBatch to a CachedBatch, I am converting it to a rowIterator and essentially writing it like an InternalRow. A more performant way to do this might be to write the file as Columnar but it can be explored as a follow-on.
Sign off empty-commit
Signed-off-by: Raza Jafri rjafri@nvidia.com