Fix 332db build failure [databricks] #10070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Grove <andygrove@nvidia.com>
|
build |
andygrove
changed the title
|
build |
tgravescs
approved these changes
Dec 18, 2023
gerashegalov
approved these changes
Dec 18, 2023
razajafri
approved these changes
Dec 19, 2023
winningsix
approved these changes
Dec 19, 2023
|
Any context on why this started to fail? The line was added 3 years ago |
razajafri
added a commit
to razajafri/spark-rapids
that referenced
this pull request
Dec 19, 2023
Is it due to new DBX Spark version we support? |
Databricks Runtime releases maintenance updates bi-weekly. So presumably in the mid-December update they relaxed the signature for Also see #8587. Of note is that per #1320 we actually do not run unit / ScalaTests on Databricks. We could stop building test jars there. |
|
build |
razajafri
added a commit
that referenced
this pull request
Dec 25, 2023
* Added 351 snapshot shim * Signing off Signed-off-by: Raza Jafri <rjafri@nvidia.com> * updated 2.13 pom.xml * Fixed Decimal 128 Multiplication * added comments to highlight the change in multiply128 * Removed the import alias * Fixed Sequence size limit check * changes to use the new multiply128. Changed the name of the shim to reflect the method name * Handle empty partitions * pulled in change from #10070 * Fixed the overflow check for addition and subtraction * Updated test conditions * Revert "Updated test conditions" This reverts commit 533504f. * addressed review comments * renamed --------- Signed-off-by: Raza Jafri <rjafri@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10063
Builds were failing with:
This PR makes the method public to fix the compilation error.