Fixes a bug where datagen seed overrides were sticky and adds datagen_seed_override_disabled #10109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_seed_override_disabled
abellina
changed the title
|
build |
Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
|
build |
1 similar comment
|
build |
|
build |
NVnavkumar
requested changes
Dec 28, 2023
|
build |
revans2
previously approved these changes
Dec 28, 2023
NVnavkumar
previously approved these changes
Dec 28, 2023
jlowe
previously approved these changes
Dec 28, 2023
Clean up by using default values Co-authored-by: Gera Shegalov <gshegalov@nvidia.com>
abellina
dismissed stale reviews from gerashegalov, jlowe, NVnavkumar, and revans2
via
a9c67a3
|
build |
NVnavkumar
previously approved these changes
Dec 28, 2023
gerashegalov
previously approved these changes
Dec 28, 2023
…abellina/spark-rapids into fix_seed_bug_and_allow_disable_override
|
build |
revans2
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10108
Fixes #10089
This is in draft mode. I haven't change the
datagen_seedsignature to include whether it is permanent or not yet.Note it fixes a bad bug as outlined here #10108.