Change unit tests that force ooms to specify the oom type (gpu|cpu) #10130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Brennan <jimb@nvidia.com>
jbrennan333
added
feature request
|
build |
1 similar comment
|
build |
|
build |
1 similar comment
|
build |
|
Thanks @gerashegalov! I've updated copyrights. Can you take another look? |
jlowe
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #10013 is merged, we can differentiate between cpu and gpu when forcing ooms in unit tests.
As we add support for host memory retries, there is the potential that some forced ooms in unit tests will cause ooms in host memory retry loops, instead of the intended gpu retry loops. This already happened with
GeneratedInternalRowToCudfRowIteratorRetrySuite, which was fixed by #10087.To prevent this, this patch changes all of the unit tests to use the longer form of
RmmSpark.forceRetryOOM|forceSplitAndRetryOOMand explicitly specify the oom injection type.