Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_window_aggs_for_batched_finite_row_windows_partitioned fail #10143

Commits on Jan 2, 2024

  1. Fix test_window_aggs_for_batched_finite_row_windows_partitioned fai…

    …lure.
    
    Fixes NVIDIA#10134.
    
    This commit fixes test failures in `test_window_aggs_for_batched_finite_row_windows_partitioned`, resulting from ambiguous
    ordering in the window function input.
    The failing tests partition by `a`, and order by `b,c`.  When the values of `b,c` have repeated values, the results from
    the window function execution is indeterminate.
    This commit changes the definition of the aggregation column `c` (that's also included in the order-by clause), to use unique
    long values.  This guarantees deterministic output.
    
    Signed-off-by: MithunR <mythrocks@gmail.com>
    mythrocks committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    ff003c4 View commit details
    Browse the repository at this point in the history